Skip to content

Add unit test to make sure issue 1297 will not be introduced again#1535

Merged
sequba merged 6 commits into
developfrom
feature/issue-1297
Oct 6, 2025
Merged

Add unit test to make sure issue 1297 will not be introduced again#1535
sequba merged 6 commits into
developfrom
feature/issue-1297

Conversation

@sequba

@sequba sequba commented Aug 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Context

Issue #1297 is not reproducible in HyperFormula 3.0.1. I am adding a unit test to ensure it will not be introduced again.

How did you test your changes?

unit tests, new unit test

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes [Bug]: set formula content includes row range will throw error! #1297

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba changed the title Add unit test to make sure issue 1297 will not be introduced again in the future Add unit test to make sure issue 1297 will not be introduced again Aug 19, 2025
@sequba sequba self-assigned this Aug 19, 2025
@sequba sequba requested a review from qunabu August 19, 2025 10:35
@github-actions

github-actions Bot commented Aug 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Performance comparison of head (b4c7df6) vs base (29178e5)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 503.75 | 505.32 | +0.31%
                                      Sheet B | 162.68 | 165.07 | +1.47%
                                      Sheet T | 143.55 | 144.36 | +0.56%
                                Column ranges | 511.52 | 507.76 | -0.74%
Sheet A:  change value, add/remove row/column |  13.92 |  13.08 | -6.03%
 Sheet B: change value, add/remove row/column | 128.76 | 129.05 | +0.23%
                   Column ranges - add column | 150.36 | 148.11 | -1.50%
                Column ranges - without batch | 442.77 | 435.75 | -1.59%
                        Column ranges - batch |  109.9 | 111.68 | +1.62%

qunabu
qunabu requested changes Sep 1, 2025
View reviewed changes

@qunabu qunabu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about Missing JSDoc comment ?

@sequba

sequba commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

what about Missing JSDoc comment ?

@qunabu, where is it missing?

@qunabu

qunabu commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

what about Missing JSDoc comment ?

@qunabu, where is it missing?

image

@sequba

sequba commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

@qunabu, this is in the files unrelated to this PR

Unchanged files with check annotations

In total, there are 3192 eslint warnings in HyperFormula. I fix them one by one whenever I work on a file containing them.

@sequba sequba force-pushed the feature/issue-1297 branch from 574b9b6 to ac77614 Compare October 6, 2025 09:04
@sequba sequba merged commit 270da75 into develop Oct 6, 2025
25 checks passed
@sequba sequba deleted the feature/issue-1297 branch October 6, 2025 09:55
@codecov

codecov Bot commented Oct 6, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (29178e5) to head (b4c7df6).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1535   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14523    14524    +1     
  Branches      3169     3169           
========================================
+ Hits         14120    14121    +1     
  Misses         396      396           
  Partials         7        7
Files with missing lines Coverage Δ
src/AbsoluteCellRange.ts 94.59% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qunabu qunabu qunabu approved these changes

Assignees

@sequba sequba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sequba @qunabu